Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33168 )
Change subject: mediatek/mt8183: set vproc12 voltage correctly
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33168/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33168/2//COMMIT_MSG@14
PS2, Line 14: Test=Boots correctly on Kukui
yes, the device can boot successfully with this wrong register. […]
You can add this to TEST line:
See that regulator is not stuck to 1.05V anymore:
grep vproc12 /sys/kernel/debug/regulator/regulator_summary
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33168
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13867b11c44019875e0ed607343197950a3b38b2
Gerrit-Change-Number: 33168
Gerrit-PatchSet: 2
Gerrit-Owner: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@chromium.org
Gerrit-Reviewer: Nicolas Boichat
drinkcat@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 18 Jun 2019 02:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: hsin-hsiung wang
hsin-hsiung.wang@mediatek.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment