Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48102 )
Change subject: [UNTESTED] soc/intel/{xeon-sp,icl,tgl,jsl,ehl,adl}: add NMI_{EN,STS} registers
......................................................................
Patch Set 18:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48102/18/src/soc/intel/xeon_sp/incl...
File src/soc/intel/xeon_sp/include/soc/lewisburg_pch_gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/48102/18/src/soc/intel/xeon_sp/incl...
PS18, Line 666: #define GPI_NMI_STS_0 0x160
: #define GPI_NMI_EN_0 0x170
That's not match with EDS 547817.that' 164/174 for community 0, 160/164/168/170/174/178 for community 1 ...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48102
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2621f4495dfd4f95f9774d9081e44c604de830a1
Gerrit-Change-Number: 48102
Gerrit-PatchSet: 18
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 06 Jan 2021 15:17:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment