Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35531 )
Change subject: Makefile: Create the build directory before bootblock.bin ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35531/3/Makefile.inc File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35531/3/Makefile.inc@507 PS3, Line 507: build-dirs $(objcbfs) $(objgenerated): Uhh... this is a bit odd. The whole point of the target 'build-dirs' is to be a phony target that creates those two directories, but now you created two more targets (those directories themselves) that also do the same thing (making 'build-dirs' kinda pointless). Why didn't you just add 'build-dirs' as a dependency to the bootblock.bin target?