build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30939 )
Change subject: nb/intel/pineview: Move to C_ENVIRONMENT_BOOTBLOCK
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30939/2/src/southbridge/intel/i82801gx/bootb...
File src/southbridge/intel/i82801gx/bootblock_gcc.c:
https://review.coreboot.org/#/c/30939/2/src/southbridge/intel/i82801gx/bootb...
PS2, Line 38: pci_write_config32(PCI_DEV(0, 0x1f, 0), RCBA, (uintptr_t)DEFAULT_RCBA | 1);
line over 80 characters
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e74838b0d5e9c192082084cfd9821996f0e4c50
Gerrit-Change-Number: 30939
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
damien@zamaudio.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Feb 2019 15:12:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment