Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42280 )
Change subject: mb/ocp/deltalake: Implement SMBIOS type 9 -- system slots by SKU ......................................................................
Patch Set 5: Code-Review+2
Patch Set 5:
Patch Set 5:
Patch Set 5: Code-Review+1
Why isn't the existing devicetree smbios type 9 mechanism used? It should be easy to modify as it's read/writable in ramstage.
I can not find the way to add PCIe root ports on IIO stack into devicetree, so I created the smbios type 9 by "slotinfo" table.
Patrick, I saw the definitions in util/sconfig/sconfig.h and the support in smbios.c, however I do not see any devicetree.cb using it, am I missing something? Today the IIO stack (as a virtual device layer) can not be defined in devicetree.cb, hence xeon_sp soc code base has its own PCIe resource allocator. Discussion is in progress with Aaron and others, I will loop you in. In the mean time, before the implementation is in place (it will take a while since PCIe resource allocator is crucial to coreboot), we need a stop-gap for SMBIOS type 9. I will note this as a to-do item for IIO support in PCIe resource allocator project.
Given that IIO isn't completely integrated within the devicetree yet, I'd say this is good enough for now.