Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42282 )
Change subject: soc/intel/tgl: Disable hybrid storage mode in recovery mode ......................................................................
Patch Set 2: Code-Review+1
(5 comments)
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@9 PS2, Line 9: CSE I see CSE and CSME being used interchangeably. Are they the same? Or does CSE refer to the hardware and CSME to the firmware (software) SKU?
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@9 PS2, Line 9: WA This is Washington! 😄
Jokes aside, I've usually seen "workaround" abbreviated as `W/A`, so I'd use that
https://review.coreboot.org/c/coreboot/+/42282/2//COMMIT_MSG@16 PS2, Line 16: Cq-Depend: chrome-internal:3100721 This tag doesn't mean anything upstream (unlike Chromium Gerrit, we don't have a CQ bot)
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... PS2, Line 259: the fix about the fix: is it something that needs to be changed in the CSME Lite SKU firmware?
https://review.coreboot.org/c/coreboot/+/42282/2/src/soc/intel/tigerlake/fsp... PS2, Line 259: WA W/A