Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33236 )
Change subject: cpu/x86: Add STM Support
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c
File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/33236/1/src/cpu/x86/mp_init.c@1042
PS1, Line 1042: #ifdef CONFIG_STM
Done
Sorry, I should have been more precise:
In coreboot we generally use if(CONFIG(STM)) { over #if CONFIG(STM).
That allows to compile all code regardless of the Kconfig settings and the linker will remove the dead code anyway.
it applies to all commits and all files and all occurences
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33236
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a0adcefc0f6e22a9da5fe53952481a77737e5eb
Gerrit-Change-Number: 33236
Gerrit-PatchSet: 10
Gerrit-Owner: Name of user not set #1002358
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Comment-Date: Fri, 07 Jun 2019 05:05:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Name of user not set #1002358
Gerrit-MessageType: comment