Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45713 )
Change subject: sb/intel/lynxpoint/pcie.c: Fix subtle blunder
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45713/2/src/southbridge/intel/lynxp...
File src/southbridge/intel/lynxpoint/pcie.c:
https://review.coreboot.org/c/coreboot/+/45713/2/src/southbridge/intel/lynxp...
PS2, Line 286: pci_or_config8(dev, 0x324, 1 << 5);
is it intended that this is not doing the same as line 287? ((1 < 5) vs (1 << 5))
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45713
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85734a68a42ec65b124d68514039a1dda7946adc
Gerrit-Change-Number: 45713
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 12 Oct 2020 21:22:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment