Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42522 )
Change subject: soc/amd/common: Drop ACPIMMIO GPIO bank separation ......................................................................
Patch Set 8: Code-Review+2
(2 comments)
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/gp... File src/soc/amd/common/block/gpio_banks/gpio.c:
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/gp... PS6, Line 98: __
Propose another prefix that gets us out of polluting global gpio_. […]
You are not polluting the global namespace, just this compilation unit. We can clean it up in a followup.
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/acpimmio.h:
https://review.coreboot.org/c/coreboot/+/42522/6/src/soc/amd/common/block/in... PS6, Line 372: static inline void gpio_write32_rb(uint8_t gpio_num, uint32_t value) : { : write32(gpio_ctrl_ptr(gpio_num), value); : read32(gpio_ctrl_ptr(gpio_num)); : } :
I agree, see CB:42825. […]
Ack