Attention is currently required from: Martin L Roth, Arthur Heymans.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67099 )
Change subject: drivers/i2c: Add a new RTC RV-3028-C7 from Micro Crystal ......................................................................
Patch Set 4:
(2 comments)
File src/drivers/i2c/rv3028c7/rv3028c7.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158030): https://review.coreboot.org/c/coreboot/+/67099/comment/022b4967_0be97bcb PS4, Line 26: if (status & EE_BUSY_BIT) { braces {} are not necessary for any arm of this statement
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-158030): https://review.coreboot.org/c/coreboot/+/67099/comment/9bb8b3d4_7b005e1a PS4, Line 89: if (i2c_dev_write_at(dev, buf, sizeof(buf), 0) != sizeof(buf)) { braces {} are not necessary for single statement blocks