Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42140 )
Change subject: ACPI: Define acpi_get_preferred_pm_profile() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42140/3/src/arch/x86/acpi_pm.c File src/arch/x86/acpi_pm.c:
https://review.coreboot.org/c/coreboot/+/42140/3/src/arch/x86/acpi_pm.c@11 PS3, Line 11: enclosure i'd put the smbios_mainboard_enclosure_type() call in the argument of the switch statement to avoid casting it to int and comparing it with the enum values then