[coreboot-gerrit] Change in coreboot[master]: soc/intel/common: Select USE_LEGACY_8254_TIMER

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34709 )

Change subject: soc/intel/common: Select USE_LEGACY_8254_TIMER
......................................................................

Patch Set 2: Code-Review-1

(1 comment)

-1, as the current approach could break other boards.
> Patch Set 2:
> > Libpayload also uses the 8254 in get_cpu_speed(). It might affect depthcharge if it's n, please verify.
>
> I have a WIP patch for libpayload, will try to clean it up soon.
> Generally, I think getting rid of the 8254 requirement is less
> work than debating this change here (exception: legacy BIOS).

Yeah, I think this would be best.

https://review.coreboot.org/c/coreboot/+/34709/2/src/soc/intel/common/block/... 
File src/soc/intel/common/block/timer/Kconfig:

https://review.coreboot.org/c/coreboot/+/34709/2/src/soc/intel/common/block/... 
PS2, Line 8: default y
> https://github. […]

Maybe add a Kconfig symbol named MAINBOARD_USES_S0IX so that USE_LEGACY_8254_TIMER depends on !MAINBOARD_USES_S0IX ?