HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37366 )
Change subject: src: Add missing include <stdlib.h> ......................................................................
Patch Set 4:
(12 comments)
commented to make this very easy to review.
https://review.coreboot.org/c/coreboot/+/37366/4/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/arch/x86/acpi_device.c@... PS4, Line 730: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/commonlib/storage/sdhci... File src/commonlib/storage/sdhci_adma.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/commonlib/storage/sdhci... PS4, Line 35: free needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/emulation/qem... PS4, Line 249: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/sifive/hifive... File src/mainboard/sifive/hifive-unleashed/fixup_fdt.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/mainboard/sifive/hifive... PS4, Line 104: malloc needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/pinev... File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/pinev... PS4, Line 460: max needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/northbridge/intel/sandy... PS4, Line 2723: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/amd/common/block/sp... PS4, Line 35: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/broadwell/me.... File src/soc/intel/broadwell/me.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/broadwell/me.... PS4, Line 875: mbp = malloc(mbp_hdr.mbp_size * sizeof(u32)); needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/block/... File src/soc/intel/common/block/fast_spi/fast_spi_flash.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/block/... PS4, Line 161: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/smbios... File src/soc/intel/common/smbios.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/common/smbios... PS4, Line 67: min needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/quark/i2c.c File src/soc/intel/quark/i2c.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/quark/i2c.c@1... PS4, Line 137: min( needs #include <stdlib.h>
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/skylake/elog.... File src/soc/intel/skylake/elog.c:
https://review.coreboot.org/c/coreboot/+/37366/4/src/soc/intel/skylake/elog.... PS4, Line 160: min( needs #include <stdlib.h>