[coreboot-gerrit] Change in coreboot[master]: soc/intel/common/block/cpu: Introduce CAR_HAS_L3_PROTECTED_WAYS Kconfig

[Subrata Banik (Code Review)]

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi, Angel Pons.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48344 )

Change subject: soc/intel/common/block/cpu: Introduce CAR_HAS_L3_PROTECTED_WAYS Kconfig
......................................................................

Patch Set 13:

(3 comments)

File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

https://review.coreboot.org/c/coreboot/+/48344/comment/09453f4f_7274541b 
PS12, Line 517: 	mov	%ebx, %ecx /* back up number of ways */
              : 	mov	%eax, %ebx /* back up the non-eviction mask*/
> I will give a try tomorrow, i hope this shouldn't take much time. […]

Ack

https://review.coreboot.org/c/coreboot/+/48344/comment/ed8fd0d2_ec6b5d98 
PS12, Line 558: %bl,
> shouldn't this be %edi (data_ways) ? ebx contains the non-eviction mask at this point

Ack

https://review.coreboot.org/c/coreboot/+/48344/comment/85794138_fc6333d1 
PS12, Line 557: 	mov	$0x01, %eax
              : 	mov	%bl, %cl
              : 	shl	%cl, %eax
              : 	subl	$0x01, %eax
> doesn't `ebx` already hold the correct value (the data ways non-eviction mask) to program into the M […]

Ack