Attention is currently required from: Maulik V Vaghela, Subrata Banik, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59666 )
Change subject: soc/intel/alderlake: Implement function to map physical port to EC port
......................................................................
Patch Set 12:
(1 comment)
File src/soc/intel/alderlake/retimer.c:
https://review.coreboot.org/c/coreboot/+/59666/comment/446678fb_3aca6607
PS9, Line 30: die("Couldn't find correct port mapping or Invalid input port\n");
I don't think we need to call die() here, returning some kind of error code is probably better (and then printing an error message at the caller).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59666
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3735b7c7794b46123aba3beac8c0268ce72d658c
Gerrit-Change-Number: 59666
Gerrit-PatchSet: 12
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 03 Dec 2021 21:25:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment