Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/23662 )
Change subject: sb/intel/i82801gx: Automatically handle disabling functions ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romst... File src/mainboard/kontron/986lcd-m/romstage.c:
https://review.coreboot.org/#/c/23662/4/src/mainboard/kontron/986lcd-m/romst... PS4, Line 221: reg32 |= 1;
Drop?
not sure if this needs to be done on each FD write or once. anyway follow-up patch will move this to ramstage...
https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i8280... File src/southbridge/intel/i82801gx/i82801gx.c:
https://review.coreboot.org/#/c/23662/4/src/southbridge/intel/i82801gx/i8280... PS4, Line 43: BIOS_INFO,
It's not that bad, is it?
leftover from i82801ix which dies here