Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46527 )
Change subject: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46527/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46527/4//COMMIT_MSG@12
PS4, Line 12: ,
Is that needed here?
No, it’s not. Thank you for spotting this.
https://review.coreboot.org/c/coreboot/+/46527/4/src/mainboard/asus/f2a85-m/...
File src/mainboard/asus/f2a85-m/devicetree_f2a85-m_pro.cb:
https://review.coreboot.org/c/coreboot/+/46527/4/src/mainboard/asus/f2a85-m/...
PS4, Line 114: # FIXME: serial console stops working when enabling resources,
This is a long line...mind to break it down a bit and move part of it to the next line? […]
Sure, do you want it below or above the line?
I haven’t analyzed yet, what the cause is. coreboot logs `Enabling resources` above the output.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d60a212b0d249c7d8b3f8ec16baf5e93c985da
Gerrit-Change-Number: 46527
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 08:54:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Werner Zeh
werner.zeh@siemens.com
Gerrit-MessageType: comment