build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/22537 )
Change subject: cbfstool: add an option for creating a topswap bootblock ......................................................................
Patch Set 4:
(14 comments)
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c File util/cbfstool/cbfstool.c:
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@344 PS4, Line 344: static int add_second_bootblock(struct buffer *buffer,uint32_t *offset) space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@347 PS4, Line 347: char* new_data = (char*)malloc(bb_size); "(foo*)" should be "(foo *)"
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@347 PS4, Line 347: char* new_data = (char*)malloc(bb_size); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@349 PS4, Line 349: if (new_data == NULL){ space required before the open brace '{'
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@353 PS4, Line 353: char* bb1_offset = new_data + "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@355 PS4, Line 355: char* bb2_offset = new_data + (bb_size - buffer->size); "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@356 PS4, Line 356: DEBUG ("bb1 offset = 0x%p, bb2 offset = 0x%p\n", space prohibited between function name and open parenthesis '('
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@410 PS4, Line 410: * topswap_size*2 bytes for bootblock to accomodate the second 'accomodate' may be misspelled - perhaps 'accommodate'?
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@414 PS4, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open brace '{'
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@414 PS4, Line 414: if(add_second_bootblock(&buffer, &offset)){ space required before the open parenthesis '('
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1340 PS4, Line 1340: " [-j topswap-size (in hex)] " code indent should use tabs where possible
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1340 PS4, Line 1340: " [-j topswap-size (in hex)] " please, no spaces at the start of a line
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1642 PS4, Line 1642: switch (param.topswap_size){ switch and case should be at the same indent
https://review.coreboot.org/#/c/22537/4/util/cbfstool/cbfstool.c@1642 PS4, Line 1642: switch (param.topswap_size){ space required before the open brace '{'