Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38522 )
Change subject: x86/acpi_device: Allow acpi_device_add_power_res params as optional ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38522/1/src/arch/x86/acpi_device.c File src/arch/x86/acpi_device.c:
https://review.coreboot.org/c/coreboot/+/38522/1/src/arch/x86/acpi_device.c@... PS1, Line 544: if (!reset_gpio && !enable_gpio && !stop_gpio) : return; :
Why was this check removed? Is there any advantage of adding power resource if none of the GPIOs are […]
We only need to define a `stop_gpio` for the _ON, _OFF methods. Removing the check lossens the assumptions of acpi_device_add_power_res() and allows it to be more general. tbh it was a bit buggy before as if they were not defined the above lines would NULL deref.
Any way the checks are done below in the function in the proper places.