Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43000 )
Change subject: post_code: add missing postcode calls
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
This looks ok, but it needs to be tested on a large number of devices before it can go in (see comment)
https://review.coreboot.org/c/coreboot/+/43000/8/src/arch/x86/bootblock_crt0...
File src/arch/x86/bootblock_crt0.S:
https://review.coreboot.org/c/coreboot/+/43000/8/src/arch/x86/bootblock_crt0...
PS8, Line 26: post_code(POST_RESET_VECTOR_CORRECT)
IIRC some early post codes were explicitly removed because they crashed some Intel platforms (BDW-DE)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43000
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia75cd863bf6ffac2c91ff78aefabc5327b1c138b
Gerrit-Change-Number: 43000
Gerrit-PatchSet: 8
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Nov 2020 22:55:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment