Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43832 )
Change subject: util/apcb: Strip SPD manufacturer information
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43832/3/src/soc/amd/picasso/Makefil...
File src/soc/amd/picasso/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43832/3/src/soc/amd/picasso/Makefil...
PS3, Line 398: --strip_manufacturer_information
I have a short shell script that I can substitute for this and call from the mainboard makefile. […]
Makes sense. Let's go ahead with this until we move to the gen_spd tool.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43832
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bbc81a858f381f62dbd38bb57b3df0e6707d647
Gerrit-Change-Number: 43832
Gerrit-PatchSet: 4
Gerrit-Owner: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jul 2020 03:31:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Rob Barnes
robbarnes@google.com
Gerrit-MessageType: comment