[coreboot-gerrit] Change in coreboot[master]: device/pciexp: Match Max_Payload_Size between ends of a link

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37769 )

Change subject: device/pciexp: Match Max_Payload_Size between ends of a link
......................................................................

Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c 
File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... 
PS1, Line 445: 	endp_devctl |= max_payload << 5;
> Oh dear :(

Ew, I missed that one.

https://review.coreboot.org/c/coreboot/+/37769/1/src/device/pciexp_device.c@... 
PS1, Line 482: }
> That's probably true for all the pciexp_xx() calls we make above. […]

Ack.  I seem to recall some inconsistent wording in the spec, so they should probably each be reconsidered independently.