Patch set 2:Code-Review +2

View Change

2 comments:

• File src/device/pciexp_device.c:

  • Patch Set #1, Line 445: endp_devctl |= max_payload << 5;

    Oh dear :(

    Ew, I missed that one.

  • Patch Set #1, Line 482: }

    That's probably true for all the pciexp_xx() calls we make above. […]

    Ack. I seem to recall some inconsistent wording in the spec, so they should probably each be reconsidered independently.

To view, visit change 37769. To unsubscribe, or for help writing mail filters, visit settings.