Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38341 )
Change subject: soc/intel/tigerlake: Update pci dev definition
......................................................................
Patch Set 10:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38341/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38341/9//COMMIT_MSG@9
PS9, Line 9: This change updates pci dev definition according to TGL EDS
Dot/period at the end of sentences please.
Ack
https://review.coreboot.org/c/coreboot/+/38341/9//COMMIT_MSG@10
PS9, Line 10: update
updated
Ack
https://review.coreboot.org/c/coreboot/+/38341/9//COMMIT_MSG@10
PS9, Line 10: Add GSPI3 case in chip.c according to update pci dev definitions
Ditto.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38341
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4717ac3cc877b13978b18ada504740512f10c709
Gerrit-Change-Number: 38341
Gerrit-PatchSet: 10
Gerrit-Owner: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jan 2020 21:02:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment