Attention is currently required from: Kane Chen, Chris Wang, chris wang.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51523 )
Change subject: mb/google/zork/var/shuboz: update USB OC pin mapping
......................................................................
Patch Set 10:
(2 comments)
File src/mainboard/google/zork/variants/baseboard/helpers.c:
https://review.coreboot.org/c/coreboot/+/51523/comment/039cf66f_93506e01
PS10, Line 115: int variant_usb_oc_pin_change(void)
I think this should be something like variant_is_convertible since we're querying that.
File src/mainboard/google/zork/variants/shuboz/variant.c:
https://review.coreboot.org/c/coreboot/+/51523/comment/071904a6_23a7bdc2
PS10, Line 50:
nit: Can you add some comments here? e.g) one of the model in shuboz variants will have additional camera attached to USB A1 so we should update OC pin settings.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51523
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc1fa090109e6be54e2a5f49e364f5502f53aca2
Gerrit-Change-Number: 51523
Gerrit-PatchSet: 10
Gerrit-Owner: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Chu
frank_chu@pegatron.corp-partner.google.com
Gerrit-CC: Hank Lin
hank2_lin@pegatron.corp-partner.google.com
Gerrit-CC: Ken Lu
ken_lu@pegatron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Attention: Kane Chen
kane_chen@pegatron.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Wed, 12 May 2021 07:34:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment