Attention is currently required from: Arthur Heymans, Patrick Rudolph, Jonathan Zhang, Paul Menzel, Jingle Hsu, Angel Pons, Nill Ge, Marc Jones, Subrata Banik, lichenchen.carl, Tim Chu, Shelly Chang.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63882 )
Change subject: arch/x86/smbios.c: Add SMBIOS type 17 for empty DIMM slots
......................................................................
Patch Set 5:
(2 comments)
File src/arch/x86/smbios.c:
https://review.coreboot.org/c/coreboot/+/63882/comment/8ad100e9_2f78aeb3
PS2, Line 280: #if CONFIG(SMBIOS_TYPE17_EMPTY_SLOT)
I mean something like: […]
Done
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/63882/comment/d276730e_b2257f8b
PS2, Line 104: uint8_t present;
Why not bool?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63882
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3ff1353667f9d3bd302db42c739b7be9d3f4a32
Gerrit-Change-Number: 63882
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Nill Ge
geshijian@bytedance.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nill Ge
geshijian@bytedance.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: lichenchen.carl
lichenchen.carl@bytedance.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly Chang
Shelly_Chang@wiwynn.com
Gerrit-Comment-Date: Mon, 02 May 2022 09:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment