Attention is currently required from: Paul Menzel, Angel Pons, Iru Cai.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46630 )
Change subject: mb/hp: Add EliteBook 820 G2 ......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/hp/elitebook_820_g2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46630/comment/514c8d6a_85851e6c PS9, Line 26: register "gen1_dec" = "0x007c0201" : register "gen2_dec" = "0x000c0101" : register "gen4_dec" = "0x000402e9" : register "gpe0_en_1" = "0x40" : register "gpe0_en_2" = "0x600" : register "gpe0_en_4" = "0x46" Same here. Goes to the LPC bridge
https://review.coreboot.org/c/coreboot/+/46630/comment/a54e1543_351c6c89 PS9, Line 33: register "sata_port1_gen3_dtle" = "0x2" : register "sata_port1_gen3_tx" = "0x80" : register "sata_port3_gen3_dtle" = "0x4" : register "sata_port3_gen3_tx" = "0x80" : # SATA (1), M.2 (3) : register "sata_port_map" = "0xa" Please move these into the scope of the SATA controller