Attention is currently required from: Paul Menzel, Timothy Pearson, Ron Minnich.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57082 )
Change subject: src/mainboard/emulation/qemu-power9: require hb-mode=on
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57082/comment/3e3949e8_76738840
PS6, Line 10: as firmware.
Sorry, I do not understand th explanation. It’d be great if you elaborated.
Sorry, I didn't notice comments on this file before. Expanded description in Patchset 9.
https://review.coreboot.org/c/coreboot/+/57082/comment/7f7095e6_f305ccdb
PS6, Line 11:
Could the memlayout be adapted in a separate commit?
No, changes to memlayout reflect change of load address caused by `hb-mode=on`.
Patchset:
PS9:
Address comments I accidentally ignored. Hope new commit message explains hb-mode=on clear enough.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57082
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1bdc97a095bd46fccc862985b3bd24f4fa5bc054
Gerrit-Change-Number: 57082
Gerrit-PatchSet: 9
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Timothy Pearson
tpearson@raptorengineering.com
Gerrit-Attention: Ron Minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 17:02:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment