Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34877 )
Change subject: mb/google/kukui: Move panel description to CBFS files ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34877/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/34877/3/src/mainboard/google/kukui/... PS3, Line 147: /* edid->mode.name is a pointer and cannot be serialized. */
Not sure what that comment is doing here, I'd rather put it in panel.h or something...
Was trying to explain why we can't use mode.name. Will remove this.
https://review.coreboot.org/c/coreboot/+/34877/3/src/mainboard/google/kukui/... PS3, Line 151: edid->y_resolution ? edid->y_resolution : edid->mode.va,
Why not just always print ha/va? That should always be the same for your case. […]
For MIPI panels I can be sure the ha is exactly x resolution, but for eDP panels I remember that may be slightly different.. although I can't find any docs pointing that anymore. Will change to ha/va.
https://review.coreboot.org/c/coreboot/+/34877/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_kukui.c:
https://review.coreboot.org/c/coreboot/+/34877/3/src/mainboard/google/kukui/... PS3, Line 51: if (desc)
Hmmm... […]
Done