Attention is currently required from: Eric Lai, Ian Feng, Nick Vaccaro, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79914?usp=email )
Change subject: mb/google/nissa/var/craaskov: Update RAM ID table
......................................................................
Patch Set 1: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79914/comment/6f391fd0_245253cb :
PS1, Line 7: Update RAM ID table
Please be more specific. Maybe:
Add Micron MT62F1G32D4DR-031 to mem_parts
https://review.coreboot.org/c/coreboot/+/79914/comment/834ba476_eac0ed7d :
PS1, Line 10:
Please mention, that it’s ID 2 somewhere.
https://review.coreboot.org/c/coreboot/+/79914/comment/80c8c498_9c8c0d03 :
PS1, Line 11: DRAM Part Name ID to assign
: MT62F512M32D2DR-031 WT:B 0 (0000)
: H9JCNNNBK3MLYR-N6E 0 (0000)
: K3LKBKB0BM-MGCP 1 (0001)
: H9JCNNNCP3MLYR-N6E 2 (0010)
: MT62F1G32D4DR-031 WT:B 2 (0010)
Why paste this?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79914?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9e54958490228beb7039d531c709d56ec244b9e7
Gerrit-Change-Number: 79914
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Rex Chou
rex_chou@compal.corp-partner.google.com
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Fri, 12 Jan 2024 11:34:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment