Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34786 )
Change subject: mb/toshiba: Add A300-1ME
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-...
File src/mainboard/toshiba/a300-1me/romstage.c:
https://review.coreboot.org/c/coreboot/+/34786/4/src/mainboard/toshiba/a300-...
PS4, Line 18: #include <arch/io.h>
: #include <device/pnp_ops.h>
: #include <device/pci_ops.h>
: #include <southbridge/intel/common/gpio.h>
: #include <southbridge/intel/i82801ix/i82801ix.h>
: #include <northbridge/intel/gm45/gm45.h>
please clean
I'll clean those once I make the EC work. See FIXMEs below
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34786
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifcdfadd2506962bc797b174b4d656e9201f7a40d
Gerrit-Change-Number: 34786
Gerrit-PatchSet: 4
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 18 May 2020 13:16:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment