Attention is currently required from: Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro.
Subrata Banik has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/85103?usp=email )
Change subject: soc/intel/alderlake: Display early Sign of Life for CSE FW Sync ......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/85103/comment/ae657a5e_d679e47f?usp... : PS1, Line 188: ux_inform_user_of_update_operation("CSE update");
We might not need extensively relocated event logging. It's currently right after the CSE sync update, which serves the purpose of event logging. The patch CB:84398 actually moved the CSE sync logging during CSE FW sync.
Furthermore, ESOL and event logging for CSE sync are two different entities. We may not need to check ESOL status; the log just informs that the CSE sync operation has been performed.
Therefore, I believe we might not need CB:85111.
sorry my bad, i missed that I have already migrated elog into CSE driver from soc local.
https://review.coreboot.org/c/coreboot/+/84398/2/src/soc/intel/common/block/...
please ignore my review comment