Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49059 )
Change subject: soc/intel/common/cse: Drop dependency on CHROMEOS for SOC_INTEL_CSE_LITE_SKU
......................................................................
Patch Set 2:
we chatted a little on IRC, just leaving some comments here for posterity:
the CSE Lite SKU FW is more of an artifact of the shipped firmware, not necessarily the build itself, so once a board ships with CSE lite FW, that's what you're pretty much stuck with; IOW, yes this seems semantically correct to me, the CSE_LITE_SKU shouldn't be dependent on CHROMEOS, per se, from a build perspective
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6959f35e1285b2fab7ea1f83a5ccfcb065c12397
Gerrit-Change-Number: 49059
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 05 Jan 2021 17:54:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment