Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38282 )
Change subject: mb/google/dedede: Enable EC ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 3: EC_ACPI
My bad. Not required.
I had some compilation error while building dsdt.asl with ec/google/chromeos/acpi/ec.asl included. I tried out different options to fix that compilation error and EC_ACPI is one of them. Finally the issue turned out to be not including the variants/ec.h header file in dsdt.asl. In the process, I forgot to remove this config. Thanks for catching it.
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/ec.c:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 31: bootblock_ec_init
Sure, will remove it.
Done
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38282/8/src/mainboard/google/dedede... PS8, Line 23: mainboard_ec_init
Just curious if there is a dependency reason that it moved to dev->init because in octopus it was do […]
Done