[coreboot-gerrit] [L] Change in coreboot[main]: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn)

[Maximilian Brune (Code Review)]

Attention is currently required from: Elyes Haouas.

Maximilian Brune has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/69066?usp=email )

Change subject: mb/*/*/irq_tables.c: Use PCI_DEVFN(dev, fn)
......................................................................

Patch Set 9: Code-Review+2

(14 comments)

File src/mainboard/asus/p2b/variants/p2b/irq_tables.c:

https://review.coreboot.org/c/coreboot/+/69066/comment/9d63f144_e37932b1?usp... :
PS9, Line 21: 		{0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/589853ce_8c3ce779?usp... :
PS9, Line 22: 		{0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/a602b5df_d67f64cd?usp... :
PS9, Line 23: 		{0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/de00d852_3516cc92?usp... :
PS9, Line 24: 		{0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/16c20c92_93b48b2e?usp... :
PS9, Line 25: 		{0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/b8c6aa9f_0cb38c4e?usp... :
PS9, Line 26: 		{0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

File src/mainboard/asus/p2b/variants/p3b-f/irq_tables.c:

https://review.coreboot.org/c/coreboot/+/69066/comment/3d257076_90ec63aa?usp... :
PS9, Line 21: 		{0x00,PCI_DEVFN(0x0c, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x1, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/472e9fa9_1bbe6e0f?usp... :
PS9, Line 22: 		{0x00,PCI_DEVFN(0x0b, 0), {{0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x01eb8}}, 0x2, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/811f2568_39d8a2dc?usp... :
PS9, Line 23: 		{0x00,PCI_DEVFN(0x0a, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x3, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/6638f70e_dd3a8d11?usp... :
PS9, Line 24: 		{0x00,PCI_DEVFN(0x09, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x4, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/76676668_af5f47f4?usp... :
PS9, Line 25: 		{0x00,PCI_DEVFN(0x0d, 0), {{0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x01eb8}}, 0x5, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/4818ba64_9235f8aa?usp... :
PS9, Line 26: 		{0x00,PCI_DEVFN(0x0e, 0), {{0x62, 0x1eb8}, {0x63, 0x1eb8}, {0x60, 0x1eb8}, {0x61, 0x01eb8}}, 0x6, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/a4c5bc0f_c5cd053f?usp... :
PS9, Line 27: 		{0x00,PCI_DEVFN(0x04, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.

https://review.coreboot.org/c/coreboot/+/69066/comment/6c464141_46902140?usp... :
PS9, Line 28: 		{0x00,PCI_DEVFN(0x01, 0), {{0x60, 0x1eb8}, {0x61, 0x1eb8}, {0x62, 0x1eb8}, {0x63, 0x01eb8}}, 0x0, 0x0},
> `space required after that ',' (ctx:VxV)`

Please fix.