Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45371 )
Change subject: mb/51nb/x210/gpio: Remove comments that contain pad functions
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45371/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45371/1//COMMIT_MSG@9
PS1, Line 9: Remove these comments, because it does not contain useful information
: that helps to understand the circuit, which we do not have.
It doesn't; the point is, that without schematics we can't really make sense of gpio. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45371
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a994a6f27d830bd05819043336d12c2ecef2f48
Gerrit-Change-Number: 45371
Gerrit-PatchSet: 2
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Mon, 28 Sep 2020 12:20:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment