Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41345 )
Change subject: mb/google/volteer: fix error in generic SPD
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41345/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/volteer/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/41345/8/src/mainboard/google/voltee...
PS8, Line 1: ##
: ##
: ##
: ## SPDX-License-Identifier: GPL-2.0-or-later
: ##
I'll clean this up in the follow-up cleanup CL discussed in comment below.
Tim, what should be done to clean this up? Strip lines 1 and 5 ? Looks like all of Hatch variant's Makefile.inc files inside their variants volter look similar (i.e. no other info in file header comment except SPDX license header).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41345
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib52bf674ebf91854d3d078015aa640aa7ee98a6f
Gerrit-Change-Number: 41345
Gerrit-PatchSet: 8
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Dossym Nurmukhanov
dossym@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 May 2020 20:23:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment