Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34540 )
Change subject: src/mainboard: Add PCI device for IUO1 and IOU2 to devicetree
......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
Ok.. I'll see if we can improve config_of() somehow.
I find your patch usefull as it has discovered this bug. Dereferencing a NULL-pointer is always a bad Idea and we were not aware of that. So your patch was and still is wellcome.
The only thing we need to think about if the die-call is the best way to handle this error.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I00a2e7ac14cf006718de55aa7a843442892d6280
Gerrit-Change-Number: 34540
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Wed, 24 Jul 2019 10:15:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment