Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39667 )
Change subject: volteer: Create halvor variant
......................................................................
Patch Set 9:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@9
PS7, Line 9: Create the halvor variant of the volteer reference
: board by copying the template files to a new directory named
: for the variant.
Please re-flow for 72/75 character line length.
Done
https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13
PS7, Line 13: Auto-Generated
Auto-generated …
Done
https://review.coreboot.org/c/coreboot/+/39667/7//COMMIT_MSG@13
PS7, Line 13: (Auto-Generated by create_coreboot_variant.sh version 3.0.0).
Please remove the brackets ().
Done
https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/39667/8/src/mainboard/google/voltee...
PS8, Line 4: SPD_SOURCES =
Okay sounds good.
Thanks for the explanation.
We will re-visit here when we need to add SPD files.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If4d3417ba55d56af441c99d949a196328d7a1951
Gerrit-Change-Number: 39667
Gerrit-PatchSet: 9
Gerrit-Owner: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Mar 2020 05:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment