Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36342 )
Change subject: sb/intel/common/spi: Add Baytrail/Braswell support ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36342/6/src/southbridge/intel/commo... File src/southbridge/intel/common/Kconfig:
https://review.coreboot.org/c/coreboot/+/36342/6/src/southbridge/intel/commo... PS6, Line 32: Idea (for follow-up?): Add `config ..._SPI_ICH7` and `select ..._COMMON_SPI` from each? Then we'd need one `select` less per platform.
https://review.coreboot.org/c/coreboot/+/36342/6/src/southbridge/intel/commo... File src/southbridge/intel/common/spi.c:
https://review.coreboot.org/c/coreboot/+/36342/6/src/southbridge/intel/commo... PS6, Line 281: #endif Does this file use `struct device` for anything but pci_*_config*()? Can't we just `#define __SIMPLE_DEVICE__`?