Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48158 )
Change subject: soc/intel/apollolake: LZ4 Compress FSP-M
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review+1
Hmm, Picasso is using LZMA. Unsure how Furquan decided on that vs. LZ4 in cb:41830.
In resource constrained environments (so pre-RAM environments) LZ4 is somewhat safer as the stack usage is quite limited. If you boot into ram you probably want the highest possible compression ratio without caring about stack usage.
As mentioned in the commit message on CB:41830, I did it primarily based on the size of the compressed binary for Picasso.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48158
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic76b51f0f3007b59ccb9f76b6a57bb9265dab833
Gerrit-Change-Number: 48158
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 01 Dec 2020 00:25:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment