Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Duncan Laurie, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48385
to look at the new patch set (#3).
Change subject: soc/intel/common/block/uart: rework to use dummy device ......................................................................
soc/intel/common/block/uart: rework to use dummy device
This change reorganizes the uart chip driver to use a dummy device instead of wrapping the actual UART controller by the chip. This is done to make the organization of the UART PCI device in the devicetree consistent with all the other internal PCI devices of the SoC i.e. without a chip around the PCI device.
Thus, with this change, UART entry in devicetrees can be changed from: ``` chip soc/intel/common/block/uart device pci xx.y hidden register "devid" = "PCI_DEVICE_ID_INTEL_XXX_UART2" end # UART #2, in ACPI mode ```
to:
``` device pci xx.y hidden chip soc/intel/common/block/uart register "devid" = "PCI_DEVICE_ID_INTEL_XXX_UART2" device generic 0 on end # Dummy UART device end end # UART #2, in ACPI mode ```
This change also corrects the devicetree of the only board currently using this driver, prodrive/hermes.
Change-Id: Ic9c9398829b52e6b0523504b862aae9aff559bc7 Signed-off-by: Felix Singer felixsinger@posteo.net Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/prodrive/hermes/variants/baseboard/overridetree.cb M src/soc/intel/common/block/uart/uart.c 2 files changed, 38 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/48385/3