Attention is currently required from: Raul Rangel, Martin L Roth, Subrata Banik, Caveh Jalali, Matt DeVillier, Nick Vaccaro, Eric Lai, Tim Van Patten, Felix Held, Boris Mittelberg.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74332 )
Change subject: ec/google/chromeec: Use either EC or MB lid switch state
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74332/comment/481356db_37ffb6c5
PS1, Line 19: TEST=Build Skyrim BIOS image and boot to OS. Trigger lid open/close
: events and ensure that they are detected properly through
: /proc/acpi/button/lid/LID0/state.
: localhost ~ # cat /proc/acpi/button/lid/LID0/state
: state: open
: localhost ~ # cat /proc/acpi/button/lid/LID0/state
: state: closed
:
: Ensure that the system behaves as expected based on powerd
: configuration. After signin, system suspends/resumes for lid close/open.
: On signin screen, system shuts down/boots for lid close/open.
Was `EC_ENABLE_LID_SWITCH` enabled or disabled for this testing? […]
I have tested with both configuration. The system behavior is not impacted. The only thing with disabling EC_ENABLE_LID_SWITCH is /proc/acpi/button/lid/LID0/state will not be present since the mainboard does not implement Lid Switch in Skyrim. That has got nothing to do with this change though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74332
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I013574d7c21761f167ad38aeed27a419677b8000
Gerrit-Change-Number: 74332
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 10 Apr 2023 22:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment