Caesar Wang has posted comments on this change. ( https://review.coreboot.org/19863 )
Change subject: google/gru: enable the pull high for touchpad ......................................................................
Patch Set 2:
(1 comment)
(1 comment)
WARNING: please, no spaces at the start of a line #11: FILE: src/mainboard/google/gru/romstage.c:72: + gpio_output(GPIO(3, B, 4), 1); /* Pull high for TP */$ total: 0 errors, 1 warnings, 19 lines checked + true
Sorry, done.
https://review.coreboot.org/#/c/19863/1//COMMIT_MSG Commit Message:
PS1, Line 19: firmware
Please mention the firmware versions.
Done. I'm no sure what's finial version in the end. (just supply the firmware for tests)
I *think* this patch is independent, that's no depend on the Elan firmware.