Attention is currently required from: V Sowmya, Balaji Manigandan, Krishna P Bhat D, Usha P.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62913 )
Change subject: mb/intel/adlrvp: Set half_populated true for ADL-N
......................................................................
Patch Set 10:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62913/comment/41b45649_f357c155
PS10, Line 9: Alder Lake N
I believe, the official spelling is Alder Lake-N. (If true, also one occurrence below.)
File src/mainboard/intel/adlrvp/romstage_fsp_params.c:
https://review.coreboot.org/c/coreboot/+/62913/comment/c1163a9c_580b4094
PS10, Line 52: AlderLake
Alder Lake
https://review.coreboot.org/c/coreboot/+/62913/comment/b2ec947a_0fb5c8e2
PS10, Line 53: Alder Lake N
I think the official spelling is Alder Lake-N.
https://review.coreboot.org/c/coreboot/+/62913/comment/e75fdad3_762795aa
PS10, Line 58: (CONFIG(BOARD_INTEL_ADLRVP_N_EXT_EC) ||
: CONFIG(BOARD_INTEL_ADLRVP_N))
Is this already a boolean, or, if not, can !! be prepended to make it one? No ternary operator needed then.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ecc3018a1ab039990ba47898ff0e0e2ede695cc
Gerrit-Change-Number: 62913
Gerrit-PatchSet: 10
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Kangheui Won
khwon@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Comment-Date: Fri, 08 Apr 2022 06:32:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment