Daniel Kang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39529 )
Change subject: src/mb/intel/tglrvp: Update camera ACPI configuration ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@9 PS5, Line 9: sensor data sheet
Please add the name and revision.
Done
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@9 PS5, Line 9: to make closer
to make *it* closer?
Done
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@10 PS5, Line 10: pin
pins?
Done
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@12 PS5, Line 12: * Clean up format
Clean-ups should be in separate commits.
The clean-up is removing unnecessary blank lines and adding missing \ to \SB. Should this be separated?
https://review.coreboot.org/c/coreboot/+/39529/5//COMMIT_MSG@17 PS5, Line 17: capture images.
Before it wasn’t possible?
User-facing camera of TGLRVP Y didn't work due to the different PWEN GPIO pin.