Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740 ......................................................................
mb/google/volteer: Fix camera dsdt config for ov2740
Link frequency and a format was not correct for volteer proto 2 ov2740 user-facing camera.
The link frequency is calculated in the following way. (max frame width * max frame height * max fps * data format in bps / number of lanes / data rate) + max 35% of overhead For ov2740, (1920 * 1080 * 60 * 10 / 2 / 2) = 311Mhz. 360Mhz after adding 18% of overhead.
BUG=b:148428976 BRANCH=none TEST=Build and boot volteer proto 2 board. Start a camera app and check user-facing camera functionalities.
Signed-off-by: Daniel Kang daniel.h.kang@intel.com Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e Reviewed-on: https://review.coreboot.org/c/coreboot/+/41157 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Dossym Nurmukhanov dossym@google.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Wonkyu Kim: Looks good to me, approved Dossym Nurmukhanov: Looks good to me, approved Daniel Kang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl index 92c0339..777ab7a 100644 --- a/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl +++ b/src/mainboard/google/volteer/variants/baseboard/include/baseboard/acpi/mipi_camera.asl @@ -124,7 +124,7 @@ Package (0x02) { "data-lanes", - Package (0x04) + Package (0x02) { One, 0x02 @@ -582,7 +582,7 @@ "link-frequencies", Package (0x01) { - 0xABA9500 + 0x15752A00 } }, Package (0x02)