Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )
Change subject: commonlib/bsd: Add new CBFS core implementation ......................................................................
Patch Set 15: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38421/15/src/commonlib/bsd/cbfs_pri... File src/commonlib/bsd/cbfs_private.c:
https://review.coreboot.org/c/coreboot/+/38421/15/src/commonlib/bsd/cbfs_pri... PS15, Line 119: assert(todo <= sizeof(*dst) - already_read); When !FATAL_ASSERTS won't the following read overflow the buffer?