Attention is currently required from: Ravi kumar. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53903 )
Change subject: libpayload: Add MMIO support in PCI lib ......................................................................
Patch Set 10:
(5 comments)
File payloads/libpayload/include/arm64/arch/io.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120405): https://review.coreboot.org/c/coreboot/+/53903/comment/b08c1e75_d7229b66 PS10, Line 154: } void function return statements are not generally useful
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120405): https://review.coreboot.org/c/coreboot/+/53903/comment/61eb119a_47ae1123 PS10, Line 159: } void function return statements are not generally useful
File src/commonlib/include/commonlib/coreboot_tables.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120405): https://review.coreboot.org/c/coreboot/+/53903/comment/35c72e21_488dddaf PS10, Line 332: uint32_t tag; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120405): https://review.coreboot.org/c/coreboot/+/53903/comment/e65fd001_922268f6 PS10, Line 333: uint32_t size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120405): https://review.coreboot.org/c/coreboot/+/53903/comment/1bdde97e_23cb3ce8 PS10, Line 334: void *config_base; please, no spaces at the start of a line