Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34337 )
Change subject: soc/intel/common: add PAD_CFG_NF_BUF_TRIG macro ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 136:
You can move your macros up here: […]
Thanks, done
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 182:
And then add your NF macro here: […]
Done
https://review.coreboot.org/c/coreboot/+/34337/2/src/soc/intel/common/block/... PS2, Line 427: pull
I honestly think that this is incorrect. […]
I think you are right, but at the same time for some boards I see
PAD_CFG_TERM_GPO(GPP_B14, 1, 20K_PD, DEEP),
https://github.com/coreboot/coreboot/blob/master/src/mainboard/intel/kblrvp/...
This is a bit confusing